some doc stuff #50
Draft
some doc stuff #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @seankross. I've been directly editing the README so I think this PR to create a vignette is out of date now. Sorry, just getting used to these workflows. I feel like we're still fairly actively updating how we do things and documenting this in the README. Are you ok with closing this, until it's more stable? |
Contributor
Author
|
Hey @stefaniebutland I did some work in this branch that I am afraid I will forget about when I get back to it, so I turned this into a draft PR. Is that okay? |
Member
|
That's great @seankross. We'll leave as is! |
Member
|
@seankross Can you please revisit this in your current round of reviews? |
Contributor
Author
|
@stefaniebutland I would like to revisit this but it's unlikely I will be able to before September 7, is that okay? |
Member
|
absolutely ok. Thank you @seankross |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.